Skip to content

docs(Window): remove centered parameter #2826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 27, 2025
Merged

docs(Window): remove centered parameter #2826

merged 3 commits into from
Mar 27, 2025

Conversation

@Tsvetomir-Hr
Copy link
Contributor

@Tsvetomir-Hr Tsvetomir-Hr commented Mar 12, 2025

@Tsvetomir-Hr Tsvetomir-Hr self-assigned this Mar 12, 2025
@Tsvetomir-Hr Tsvetomir-Hr requested review from a team as code owners March 12, 2025 12:16
dimodi
dimodi requested changes Mar 12, 2025
View reviewed changes
Copy link
Contributor

@dimodi dimodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Explain how to center the Window initially by not using Top and Left at all, or y setting them to string.Empty.
  • Enhance the "Top and Left" example with the button that centers the Window back.

@Tsvetomir-Hr
Copy link
Contributor Author

Tsvetomir-Hr commented Mar 12, 2025

  • Explain how to center the Window initially by not using Top and Left at all*

For this, I can add at the beginning of the article that if these parameters are not defined the Window will be in the center. Is that good for you @dimodi ?

  • Enhance the "Top and Left" example with the button that centers the Window back.*

If I update the example to center the window through a button what will be the purpose of the KB? #2821

@Tsvetomir-Hr Tsvetomir-Hr requested a review from dimodi March 13, 2025 11:45
dimodi
dimodi reviewed Mar 18, 2025
View reviewed changes
dimodi
dimodi reviewed Mar 18, 2025
View reviewed changes
dimodi
dimodi reviewed Mar 18, 2025
View reviewed changes
dimodi
dimodi reviewed Mar 18, 2025
View reviewed changes
dimodi
dimodi reviewed Mar 18, 2025
View reviewed changes
dimodi
dimodi reviewed Mar 18, 2025
View reviewed changes
@Tsvetomir-Hr Tsvetomir-Hr requested a review from dimodi March 18, 2025 15:17
dimodi
dimodi reviewed Mar 27, 2025
View reviewed changes
dimodi
dimodi reviewed Mar 27, 2025
View reviewed changes
dimodi
dimodi reviewed Mar 27, 2025
View reviewed changes
dimodi
dimodi reviewed Mar 27, 2025
View reviewed changes
@Tsvetomir-Hr Tsvetomir-Hr force-pushed the window-remove-center-docs branch from 262cc2a to 95a9861 Compare March 27, 2025 09:49
@Tsvetomir-Hr Tsvetomir-Hr requested a review from dimodi March 27, 2025 09:49
dimodi
dimodi reviewed Mar 27, 2025
View reviewed changes
@Tsvetomir-Hr Tsvetomir-Hr merged commit 87f0803 into master Mar 27, 2025
@github-actions github-actions bot deleted the window-remove-center-docs branch March 27, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dimodi dimodi dimodi approved these changes

@yordan-mitev yordan-mitev yordan-mitev approved these changes

@xristianstefanov xristianstefanov xristianstefanov approved these changes

Assignees

@Tsvetomir-Hr Tsvetomir-Hr

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Tsvetomir-Hr @dimodi @yordan-mitev @xristianstefanov